block in Publish state when message sending fails due to lack of funds #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
force-pushed
the
nonsense/retry-in-publish-deal
branch
from
fdbd21f
to
0131e1c
Compare
3 tasks
nonsense
force-pushed
the
nonsense/retry-in-publish-deal
branch
2 times, most recently
from
1622db3
to
86f01aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
==========================================
+ Coverage 65.22% 65.41% +0.20%
==========================================
Files 62 62
Lines 4467 4472 +5
==========================================
+ Hits 2913 2925 +12
+ Misses 1273 1265 -8
- Partials 281 282 +1
Continue to review full report at Codecov.
|
nonsense
force-pushed
the
nonsense/retry-in-publish-deal
branch
from
86f01aa
to
eebce51
Compare
…ishDeal errors with not enough funds error
Merged
rvagg
pushed a commit
that referenced
this pull request
Oct 15, 2021
#638) * PublishDeal: do not return an error when lacking funds * unit test: make sure that we stay in StorageDealPublish state if PublishDeal errors with not enough funds error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix: filecoin-project/lotus#7102
Change in behaviour here is that if
PublishDealsfails withnot enough fundswe don't fail permanently the deal, but consider this a transient error, and we just block the deal in thePublishstate - waiting for an action from the user, or for a restart of the node to try again.We opted against automatic retry, because it is hard to predict for how long a deal has to be retried.