Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/find providers #43

Merged
merged 4 commits into from
Jan 15, 2020
Merged

Feat/find providers #43

merged 4 commits into from
Jan 15, 2020

Conversation

shannonwells
Copy link
Contributor

@shannonwells shannonwells commented Jan 14, 2020 •
edited
Loading

Closes Zenhub Retrieval Market Project Issue #12

Implement client.FindProviders method which just calls PeerResolver.GetPeers with the desired PieceCID; unit test with test PeerResolver

hannahhoward
hannahhoward approved these changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, so, this is LGTM, but...

I'm mildly horrified to see I have GetPeers taking a CID instead of bytes, because it is a commP.... eek!

Would you have time to change that as part of this PR? If not it can be done seperately.

@shannonwells
Copy link
Contributor Author

I have GetPeers taking a CID instead of bytes, because it is a commP...Would you have time to change that as part of this PR? If not it can be done seperately.

Meh, I think it's fine to change it before merging.

hannahhoward
hannahhoward reviewed Jan 15, 2020
View reviewed changes
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For expiditing reasons I'm not marking this request changes, but please change the new test to use TestRetrievalClientNode for consistency, unless there is a compelling reason not to.

retrievalmarket/impl/client_test.go Outdated Show resolved Hide resolved
@shannonwells shannonwells merged commit d03e1c2 into master Jan 15, 2020
@shannonwells shannonwells deleted the feat/find-providers branch January 15, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahhoward hannahhoward hannahhoward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shannonwells @hannahhoward