Upgrade IPLD-prime to latest #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade IPLD prime to latest, with breaking changes to syntax
shannonwells
approved these changes
Apr 30, 2020
| LinkNodeBuilderChooser: chooser, | ||
| Ctx: ctx, | ||
| LinkLoader: loader, | ||
| LinkTargetNodeStyleChooser: chooser, |
There was a problem hiding this comment.
Nit: can this be a shortened at all?
There was a problem hiding this comment.
File under: requests for @warpfork
There was a problem hiding this comment.
I confess I hate this one too, but it does what it says on the tin. I haven't thought of a shorter name.
shared_testutil/mocknet.go
Outdated
| Ds2 datastore.Batching | ||
| DTStoredCounter1 *storedcounter.StoredCounter | ||
| DTStoredCounter2 *storedcounter.StoredCounter | ||
| StoredCounter1 *storedcounter.StoredCounter |
There was a problem hiding this comment.
Can this be called DIDStoredCounter1 & 2 like the ones above? or DealStoredCounter1 &2?
shared_testutil/test_ipld_tree.go
Outdated
| mb.Insert(knb.CreateString("nonlink"), vnb.CreateString("zoo")) | ||
| })) | ||
| middleMapNode, middleMapNodeLnk = encode(fluent.MustBuildMap(basicnode.Style.Map, 3, func(ma fluent.MapAssembler) { | ||
| nva := ma.AssembleEntry("foo") |
There was a problem hiding this comment.
You can actually chain these and cut your lines almost in half. I just made the changes and all the tests still pass:
Suggested change
| nva := ma.AssembleEntry("foo") | |
| ma.AssembleEntry("foo").AssignBool(true) | |
| ma.AssembleEntry("bar").AssignBool(false) | |
| ma.AssembleEntry("nested").CreateMap(2, func(ma fluent.MapAssembler) { | |
| ma.AssembleEntry("alink").AssignLink(leafAlphaLnk) | |
| ma.AssembleEntry("nonlink").AssignString("zoo") | |
| }) | |
| })) | |
| middleMapBlock, _ = blocks.NewBlockWithCid(storage[middleMapNodeLnk], middleMapNodeLnk.(cidlink.Link).Cid) | |
| middleListNode, middleListNodeLnk = encode(fluent.MustBuildList(basicnode.Style.List, 4, func(la fluent.ListAssembler) { | |
| la.AssembleValue().AssignLink(leafAlphaLnk) | |
| la.AssembleValue().AssignLink(leafAlphaLnk) | |
| la.AssembleValue().AssignLink(leafBetaLnk) | |
| la.AssembleValue().AssignLink(leafAlphaLnk) | |
| })) | |
| middleListBlock, _ = blocks.NewBlockWithCid(storage[middleListNodeLnk], middleListNodeLnk.(cidlink.Link).Cid) | |
| rootNode, rootNodeLnk = encode(fluent.MustBuildMap(basicnode.Style.Map, 4, func(ma fluent.MapAssembler) { | |
| ma.AssembleEntry("plain").AssignString("olde string") | |
| ma.AssembleEntry("linkedString").AssignLink(leafAlphaLnk) | |
| ma.AssembleEntry("linkedMap").AssignLink(middleMapNodeLnk) | |
| ma.AssembleEntry("linkedList").AssignLink(middleListNodeLnk) | |
| })) |
There was a problem hiding this comment.
cool! cc: @warpfork this makes for a wonderfully concise syntax
use conscise syntax for test tree and rename stored counters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Upgrade to go-ipld-prime & graphsync to latest
Implementation