Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow custom runners usage in the Go Test workflow #750

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Nov 21, 2024

This is a follow-up to the discussions we've been having at https://ipdx-workspace.slack.com/archives/C03KLC57LKB/p1730963666791569

I forgot about this limitation before. In this PR I pointed the go-test at the fork of https://github.com/ipdxco/unified-github-workflows that lives in filecoin-project org https://github.com/filecoin-project/unified-github-workflows. By doing that, we'll be able to set up custom runners for the workflow via the repo config vars.

What's also worth noting is that https://github.com/filecoin-project/unified-github-workflows is kept up-to-date automatically by https://github.com/ipdxco/unified-github-workflows/actions/workflows/sync-forks.yml (so it doesn't introduce any additional manual maintenance burden whatsoever).

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.26%. Comparing base (c92e6d4) to head (f8eb94e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   69.80%   69.26%   -0.54%     
==========================================
  Files          74       74              
  Lines        7497     7497              
==========================================
- Hits         5233     5193      -40     
- Misses       1856     1887      +31     
- Partials      408      417       +9     

see 4 files with indirect coverage changes

---- 🚨 Try these New Features:

@@ -16,6 +16,6 @@ concurrency:

jobs:
go-test:
uses: ipdxco/unified-github-workflows/.github/workflows/[email protected]
uses: filecoin-project/unified-github-workflows/.github/workflows/[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious as to why only go-test workflow is updated. Do we want to consistently use the workflows from filecoin-project fork?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily, we only need to use workflows from the fork in filecoin-project in the workflows where we want to use custom GitHub runners.

The fork and the origin are kept identical automatically. The fork only exists to overcome the limitation that disallows usage of self-hosted runners in reusable workflows that live outside the org.

@Stebalien Stebalien added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 473ad59 Nov 21, 2024
13 checks passed
@Stebalien Stebalien deleted the go-test-custom-runners branch November 21, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants