-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel monitor watches for errors instead of measuring data rate #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
feat/chanmon-retrieval
branch
2 times, most recently
from
April 8, 2021 12:14
8f97b44
to
099aa0e
Compare
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 65.42% 64.95% -0.47%
==========================================
Files 25 25
Lines 2600 2594 -6
==========================================
- Hits 1701 1685 -16
- Misses 558 568 +10
Partials 341 341
Continue to review full report at Codecov.
|
dirkmc
force-pushed
the
feat/chanmon-retrieval
branch
from
April 8, 2021 12:21
099aa0e
to
1d99682
Compare
dirkmc
added
the
x/ignite
Issues and PRs being tracked by Team Ignite at Protocol Labs
label
Apr 9, 2021
8 tasks
nonsense
reviewed
Apr 9, 2021
nonsense
approved these changes
Apr 9, 2021
dirkmc
force-pushed
the
feat/chanmon-retrieval
branch
from
April 15, 2021 12:25
8f19d0a
to
10de9cb
Compare
dirkmc
force-pushed
the
feat/chanmon-retrieval
branch
from
April 16, 2021 13:30
720f4bd
to
6798477
Compare
nonsense
reviewed
Apr 16, 2021
nonsense
reviewed
Apr 16, 2021
This was referenced May 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ipfs/go-graphsync#164
Supercedes #177 #172 #182 #181
Currently the channel monitor watches the data-rate and if it falls too low, the monitor sends a Restart message to the other party in the data transfer.
This is complex to do for retrieval deals, because the monitor needs to be aware of pauses and resumes.
Instead this PR simplifies the monitor's behaviour so that now: