Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verify-by-api documentation for FILFOX #2313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xBalbinus
Copy link
Contributor

No description provided.


This section provides detailed documentation for the Filfox Contract Verification API. The API allows you to verify your smart contracts programmatically, and is the recommended method for verifying contracts. Below, you will find information on how to use the API, including the available endpoints, request and response formats, and example code snippets.

Please refer to the [documentation](https://filfox.info/api/v1/docs/static/index.html) for more information on how to verify contracts using the Filfox API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation links to Filfox API Documents which does not include verifyContract API. Is it a wrong link? Or maybe we can just remove it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xBalbinus can you address the comments, so we can get this merged?

@@ -25,6 +25,196 @@ The following guide walks you through the process of contract verification using
* [Remix](https://remix.ethereum.org/)

### Procedure
#### Via. API (Recommended)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same content as Filfox docs. I am wondering if this is necessary to have the same content here in Filecoin docs to bring the extra work of maintaining here comparing with just providing a link to it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @longfeiWan9, I think a better option would be to list the different platforms that do contract verification, like at the top of this document, and then under each platform list links to their tutorials.

@@ -25,6 +25,196 @@ The following guide walks you through the process of contract verification using
* [Remix](https://remix.ethereum.org/)

### Procedure
#### Via. API (Recommended)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is the recommended way of verifying the contract?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants