Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: spark contract #377

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: spark contract #377

wants to merge 18 commits into from

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Jan 21, 2025 •
edited
Loading

  • Contract
  • Test - contract
  • Auto update process
  • Delete command
  • Test in mainnet
  • README

bajtos
bajtos reviewed Jan 29, 2025
View reviewed changes
Copy link

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the design and have concerns about the feasibility/usability of the proposed solution. PTAL at my comments below.

market/ipni/ipni-provider/spark.go Show resolved Hide resolved
market/ipni/spark/sol/README.md Show resolved Hide resolved
market/ipni/spark/sol/README.md Outdated Show resolved Hide resolved
market/ipni/spark/sol/README.md Outdated Show resolved Hide resolved
@LexLuthr LexLuthr force-pushed the feat/spark-contract branch from 37d479e to e174761 Compare January 31, 2025 08:37
@LexLuthr LexLuthr force-pushed the feat/spark-contract branch from e174761 to f4aa99b Compare January 31, 2025 08:42
@LexLuthr LexLuthr force-pushed the feat/spark-contract branch from fec0bf3 to 652fbac Compare January 31, 2025 10:02
@LexLuthr LexLuthr force-pushed the feat/spark-contract branch from 652fbac to 0ddc513 Compare January 31, 2025 10:04
This was referenced Jan 31, 2025
Open
Open
bajtos
bajtos approved these changes Jan 31, 2025
View reviewed changes
Copy link

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for simplifying the contract!

I have a few comments to consider, see above.

The new version looks good to me 👍🏻 Can you please let me know what is the address of the mainnet deployment we can use in Spark and the FRC?

@LexLuthr LexLuthr marked this pull request as ready for review February 6, 2025 13:52
@LexLuthr LexLuthr requested a review from magik6k February 11, 2025 10:09
@LexLuthr
Copy link
Contributor Author

Thank you for simplifying the contract!

I have a few comments to consider, see above.

The new version looks good to me 👍🏻 Can you please let me know what is the address of the mainnet deployment we can use in Spark and the FRC?

https://github.com/filecoin-project/curio/pull/377/files#diff-d85ad0e746ee905070323ee7d58e78f5f1c2f7d23f076a184ff577c38472263dR22 has the contract address.

bajtos
bajtos approved these changes Feb 14, 2025
View reviewed changes
Copy link

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discovered a bug in the example code in README, I think it's important to fix it. It's not preventing this pull request from being landed, though.

I also have a suggestion to rename signedMessage to signature, but I understand it may not be important enough at this stage.

market/ipni/spark/sol/README.md Outdated Show resolved Hide resolved
market/ipni/spark/sol/README.md Outdated Show resolved Hide resolved
market/ipni/spark/sol/README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@magik6k magik6k Awaiting requested review from magik6k

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LexLuthr @bajtos @magik6k