Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid double-panic on test failure #929

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix: avoid double-panic on test failure #929

merged 1 commit into from
Dec 8, 2022

Conversation

Stebalien
Copy link
Member

No description provided.

vyzo
vyzo approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you know, the intentions of that drop thing were good, but its such a loser throw.
We have to stop accepting these good intention patches.

@Stebalien
Copy link
Member Author

No, we really needed this patch.

@Stebalien Stebalien enabled auto-merge (squash) December 8, 2022 19:59
@Stebalien Stebalien merged commit 5077e82 into master Dec 8, 2022
@Stebalien Stebalien deleted the test/double-panic branch December 8, 2022 20:11
shamb0 pushed a commit to shamb0/builtin-actors that referenced this pull request Jan 31, 2023
@Stebalien @shamb0
fix: avoid double-panic on test failure (filecoin-project#929)
f678790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

@mriise mriise Awaiting requested review from mriise

@maciejwitowski maciejwitowski Awaiting requested review from maciejwitowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @vyzo