Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datacap: fix Name and Symbol methods #794

Merged
merged 1 commit into from
Oct 31, 2022
Merged

datacap: fix Name and Symbol methods #794

merged 1 commit into from
Oct 31, 2022

Conversation

arajasek
Copy link
Contributor

I don't think calls to these methods will ever succeed right now.

2 changes:

  • receive no params beside the runtime (cf. Miner::control_addresses)
  • validate the caller (accept any), because all methods must do this.

And add a test.

anorth
anorth approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, we have got to fix this serialisation mess so that we can have a single type signature for all exported methods.

@arajasek arajasek enabled auto-merge (squash) October 31, 2022 14:16
@arajasek arajasek merged commit d4c7346 into master Oct 31, 2022
@arajasek arajasek deleted the asr/datacap-fixes branch October 31, 2022 14:32
geoff-vball pushed a commit that referenced this pull request Oct 31, 2022
@arajasek @geoff-vball
datacap: fix Name and Symbol methods (#794)
c5ffe2b
@geoff-vball geoff-vball mentioned this pull request Oct 31, 2022
Merged
arajasek added a commit that referenced this pull request Oct 31, 2022
@geoff-vball @arajasek
backport: datacap: fix Name and Symbol methods (#798)
68e951d 
datacap: fix Name and Symbol methods (#794)

Co-authored-by: Aayush Rajasekaran <[email protected]>
shamb0 pushed a commit to shamb0/builtin-actors that referenced this pull request Jan 31, 2023
@arajasek @shamb0
datacap: fix Name and Symbol methods (filecoin-project#794)
5bafeff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anorth anorth anorth approved these changes

@ZenGround0 ZenGround0 ZenGround0 approved these changes

Assignees
No one assigned
Labels
release/backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arajasek @anorth @ZenGround0