Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgotten commit for the #650 #702

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Forgotten commit for the #650 #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions actors/miner/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4863,12 +4863,10 @@ impl ActorCode for Actor {
let res = Self::prove_replica_updates(rt, cbor::deserialize_params(params)?)?;
Ok(RawBytes::serialize(res)?)
}
#[allow(unreachable_code)]
Some(Method::PreCommitSectorBatch2) => {
Self::pre_commit_sector_batch2(rt, cbor::deserialize_params(params)?)?;
Ok(RawBytes::default())
}
#[allow(unreachable_code)]
Some(Method::ProveReplicaUpdates2) => {
let res = Self::prove_replica_updates2(rt, cbor::deserialize_params(params)?)?;
Ok(RawBytes::serialize(res)?)
Expand Down
4 changes: 0 additions & 4 deletions actors/miner/tests/miner_actor_test_precommit_batch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,10 +314,6 @@ mod miner_actor_precommit_batch {
#[test_case(false; "v1")]
#[test_case(true; "v2")]
fn duplicate_sector_rejects_batch(v2: bool) {
// This test does not enumerate all the individual conditions that could cause a single precommit
// to be rejected. Those are covered in the PreCommitSector tests, and we know that that
// method is implemented in terms of a batch of one.

let period_offset = ChainEpoch::from(100);

let h = ActorHarness::new_with_options(HarnessOptions {
Expand Down