Verifreg uses a constant for datacap token actor addr, rather than state. #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## decouple-fil+ #624 +/- ##
================================================
Coverage ? 84.03%
================================================
Files ? 95
Lines ? 18916
Branches ? 0
================================================
Hits ? 15896
Misses ? 3020
Partials ? 0 |
anorth
force-pushed
the
anorth/hardcode-datacap
branch
from
bc7c7bf to
38279cb
Compare
ZenGround0
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ZenGround0 challenged me on this earlier, and now I think I was wrong. We'll be deploying new code any time this could possibly change anyway.
I still think the datacap token actor holding the address of its governor (the verified registry) in state makes sense, so that the datacap actor has no conceptual dependency back on the other builtins.