feat: Implement FIP-0044 #502
Conversation
actors/account/src/lib.rs
Outdated
| } | ||
| }; | ||
| let sig = Signature { sig_type, bytes: params.signature }; | ||
| rt.verify_signature(&sig, &st.address, ¶ms.message).map_err(|e| { |
There was a problem hiding this comment.
| rt.verify_signature(&sig, &st.address, ¶ms.message).map_err(|e| { | |
| rt.verify_signature(&sig, &address, ¶ms.message).map_err(|e| { |
arajasek
force-pushed
the
asr/authenticate-message
branch
from
47e4e37 to
f979b8a
Compare
arajasek
force-pushed
the
asr/authenticate-message
branch
from
f979b8a to
c099a0e
Compare
arajasek
changed the title
arajasek
force-pushed
the
asr/authenticate-message
branch
from
c099a0e to
e291350
Compare
|
@anorth This is ready for another round of review (maybe even final round). |
arajasek
force-pushed
the
asr/authenticate-message
branch
2 times, most recently
from
04f0e63 to
e2bbeba
Compare
There was a problem hiding this comment.
Please add a unit test to the account actor. Thanks for the VM test.
Either we don't have any integration tests for deals, or those tests don't make any assertions about the expected invocations from the call trace. Assuming the latter, could you add an ExpectInvocation to at least one of the PSD integration tests please?
arajasek
force-pushed
the
asr/authenticate-message
branch
5 times, most recently
from
849008e to
bbdb4e4
Compare
|
@anorth Done -- this now has both unit and integ test coverage of both the account and market changes. |
| @@ -20,6 +20,7 @@ num-traits = "0.2.14" | |||
| num-derive = "0.3.3" | |||
| fvm_ipld_blockstore = "0.1.1" | |||
| fvm_ipld_encoding = "0.2.2" | |||
| anyhow = "1.0.56" | |||
There was a problem hiding this comment.
Noooo, we're trying to kill this. It looks like it's only come in to a test, which I could believe is necessary due to existing use of anyhow. But if it's easy to avoid, I'd prefer that.
There was a problem hiding this comment.
Yeah, unfortunately it'd be a bit much to change the runtime test_utils here.
arajasek
force-pushed
the
asr/authenticate-message
branch
from
bbdb4e4 to
6a3dd21
Compare
|
@jennijuju Yes |
* feat: add authenticate message to account actor * hook up market actor to call new authenticate_message method * fixup and add tests
* feat: add authenticate message to account actor * hook up market actor to call new authenticate_message method * fixup and add tests
This PR is a prototype of filecoin-project/FIPs#413 for illustrative purpsoses.
UPDATE: The FIP draft has since been opened. It uses a different name for the method than this PR, we'll reconcile them based on which is better received.
resolves #533