Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP Discussion: Snap Deals #145

Closed
Kubuxu opened this issue Aug 24, 2021 · 5 comments
Closed

FIP Discussion: Snap Deals #145

Kubuxu opened this issue Aug 24, 2021 · 5 comments
Labels
Last Call This FIP draft is complete, and final community input and feedback is welcome. v15 Upgrade This proposal seeks on-chain network acceptance in the v15 network upgrade

Comments

@Kubuxu
Copy link
Contributor

Kubuxu commented Aug 24, 2021

Discussion issue for FIP-XXXX
Replaces FIP-0017 (#131)

Motivation

Unlocking currently available CC sectors (8EiB) for deals by allowing CC to be updated to contain deals in a lightweight and fast process.

Differences from FIP-0017

  • Update is now one message process with no waiting for randomness involved. Time to complete the upgrade reduced from 3h to less than 30min.
  • Encoding function changed slightly with a minimal compute cost increase (computing 512 Posseidon hashes).
  • Proof creation cost is slightly increased (10%) to enable cheap verification.
  • Proof verification cost is radically reduced by performing challenge generation in the circuit.

FIP draft to follow soon

kaitlin-beegle added a commit that referenced this issue Aug 24, 2021
Merging updates to maintain the most 'up-to-date' version of FIP-0017, in terms of work completed.  

Beginning today with the publication of the snap deal proposal (#145), draft FIP-0017 will be moved to 'DEFERRED' status.
@kaitlin-beegle kaitlin-beegle added Technical - Proofs FIP0019 Links an existing discussion item to an existing FIP. labels Aug 24, 2021
@kaitlin-beegle
Copy link
Contributor

Additional context: lightweight sector updates for faster sealing times is a topic that has been proposed multiple times, and with multiple iterations. Most recently, FIP-0017 (draft) was proposed to address this topic. However, it was decided that this FIP ought to be deferred in favor of the 'snap deals' approach.

This discussion post precedes a new FIP proposal, FIP-0019, which will soon be available to the community for review.

Please comment below with any questions you may have about this proposal and/or the decision to defer the earlier FIP iteration.

@stuberman
Copy link

I am wondering about security considerations. Without resealing a sector, doesn't this violate the integrity of a sector? More to the point, does this open the door to modifying content of a sector without the security provided by the original proof?

@ZenGround0
Copy link
Contributor

It does not. If you can find a way to do this you have found a currently unknown attack on the snap deals upgrade construction that would require a security modification for the FIP to make it to mainnet.

I'm not an expert here but the general property of sectors providing the system security is that sectors are not cheap to compress. The snap deals upgrade mechanism is carefully designed to maintain this incompressibility property. Conceptually the reason we expect this to be possible at all is that the upgrade starts with an incompressible sector and maintains an acceptable level of incompressibility while combining user data with the sector.

@kaitlin-beegle
Copy link
Contributor

kaitlin-beegle commented Sep 2, 2021

FYI - Snap Deals were discussed in various Storage Provider meetings today and several concerns were raised. These include general questions about security, as well as specific concerns about snap deals disproportionately incentivizing CC sector creation.

The various storage provider working groups, etc., would like to weigh in on whether or not the upgrade is configured to support sending 1 or 2 messages. However, more information is needed. I'll be working to gather additional information from various stakeholders over the course of the next week and sharing it across various Slack channels.

@Kubuxu do you have a timeline or roadmap for the full FIP draft being completed?

@kaitlin-beegle kaitlin-beegle added v15 Upgrade This proposal seeks on-chain network acceptance in the v15 network upgrade and removed Technical - Proofs FIP0019 Links an existing discussion item to an existing FIP. labels Jan 3, 2022
@kaitlin-beegle kaitlin-beegle added the Last Call This FIP draft is complete, and final community input and feedback is welcome. label Jan 11, 2022
@kaitlin-beegle
Copy link
Contributor

This FIP officially moved to 'accepted' status on 1/24! Closing issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Last Call This FIP draft is complete, and final community input and feedback is welcome. v15 Upgrade This proposal seeks on-chain network acceptance in the v15 network upgrade
Projects
None yet
Development

No branches or pull requests

4 participants