Laravel 11

[danharrin]

Issues

• Service provider auto-registration
• Tests are failing due to database setup issue

Dependencies that need updating for core packages to function:

• https://github.com/AnourValar/eloquent-serialize
• https://github.com/kirschbaum-development/eloquent-power-joins

Dependencies that need updating for CI to function:

• https://github.com/spatie/laravel-medialibrary
• https://github.com/spatie/laravel-ray
• https://github.com/spatie/eloquent-sortable
• https://github.com/spatie/laravel-tags
• https://github.com/staudenmeir/belongs-to-through
• https://github.com/staudenmeir/eloquent-has-many-deep

[tisuchi]

Hi @danharrin

Thanks for the nice work.

Does it mean that we need to Laravel 11 to merge this pull request?

If we want to install filament with laravel 11-dev, is there any way to do that?

[danharrin]

If you would like to use it, you can contribute to eloquent-serialize and power-joins with Laravel 11 support. Once those packages have support, we can merge this PR.

[atmonshi]

is there any knowing issues with eloquent-serialize and L11?
aside from adding |^11.0?
test it with fresh installation L11 seems all fine.

$package = EloquentSerializeFacade::serialize(
        \App\Models\User::query()
            ->limit(2)
    );

    dump($package);
    
    $builder = EloquentSerializeFacade::unserialize($package);
    foreach ($builder->get() as $item) {
        dump($item);
    }

[danharrin]

I can't imagine there will be issues, just needs to be a PR

[staudenmeir]

https://github.com/staudenmeir/belongs-to-through
https://github.com/staudenmeir/eloquent-has-many-deep

Both packages now have versions for Laravel 11. The constraints in your composer.json don't need to be changed.

[danharrin]

Thanks @staudenmeir, will watch out for the tags

[danharrin]

I'm still unable to run CI because of spatie/eloquent-sortable which is required by spatie/laravel-tags @mokhosh

[mokhosh]

I'm still unable to run CI because of spatie/eloquent-sortable which is required by spatie/laravel-tags @mokhosh

on it @danharrin spatie/eloquent-sortable#171

[mokhosh]

spatie/eloquent-sortable#171 done @danharrin

[mokhosh]

https://github.com/spatie/eloquent-sortable/releases/tag/4.2.0 tagged 🎉

👀

[mokhosh]

The failed tests seem to be related to LazilyRefreshDatabase but there are only two v10 changes to this trait. I didn't see any changes to it on master.
These are the changes:
laravel/framework#49853
laravel/framework#49914

It could also be https://github.com/laravel/framework/commits/master/src/Illuminate/Foundation/Testing/RefreshDatabase.php

[danharrin]

The first error is about a table not existing, maybe the rest of the errors are caught up because of that. Seems like maybe our migrations don't get picked up

[danharrin]

Seems to be a similar issue here, but it might be Passport related spatie/laravel-permission#2605

[mokhosh]

im on mobile, and github is clunky on mobile, but i would check how laravel/passport has adapted its tests on master to support laravel11

[danharrin]

The PR I sent has not had the issue solved

[mokhosh]

I went through laravel/framework PRs and commits, but now I'm thinking it's a testbench issue. I created an issue here: orchestral/testbench#393

[danharrin]

Thanks to @crynobone, the tests are now passing!

[mokhosh]

Awesome, thanks @crynobone and @danharrin

[AJenbo]

Glad to see you managed to solve it 👍

[marcelloinfoweb]

Any news about this?

[mokhosh]

@marcelloinfoweb about what man?

[marcelloinfoweb]

@marcelloinfoweb about what man?

If Filament is already supported in Laravel 11

[mokhosh]

It sure is @marcelloinfoweb