Added Security model.
#12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mal numbers and check if the current key is contained in it (makes things more readable, especially with more keys to come).
|
No idea why the build for 1.9.3 failed; the log on Travis CI seems to be empty. |
…pproved) accounts.
|
I've added the aforementioned method to retrieve all securities (equivalent to what's done in the Python library) as well. |
… Travis CI uses an old, buggy version of bundler).
|
Included fix from PR #13 to make the builds pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it makes sense to include this in the official library.
The approach to define which keys' values should be treated as which type has its limitations, though. Maybe a per-model list of
(key, type_function)pairs is more flexible?While I was able to fetch all available securities for all of the current user's accounts via
session.query_api_object Security, '/rest/securities', nil, 'GET', 'securities', this approach ignores other keys besides"securities"in the JSON response (namely"deleted"and"status"); the Ruby library does not seem to provide an easy way to handle those as well. This is why I haven't added any methods to the session class, yet.Then again, the equivalent method in the Python library seems to ignore the other keys as well.