Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make winston a dependency #32

Closed
levino opened this issue Jan 24, 2017 · 0 comments
Closed

Make winston a dependency #32

levino opened this issue Jan 24, 2017 · 0 comments

Comments

@levino
Copy link
Contributor

levino commented Jan 24, 2017

Here you use the package winston for prod code, but it is only a dev dependency. Makes the package unusable for third parties.
@levino levino changed the title Make winston a depdency Make winston a dependency Jan 24, 2017
levino added a commit to levino/node-figo that referenced this issue Jan 30, 2017
@levino
Making winston a proper dep instead of dep dependency. Fixes figo-con…
759c1b5 
…nect#32
@levino levino mentioned this issue Jan 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@levino