Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plotting series when the first data point is empty #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix plotting series when the first data point is empty #59

wants to merge 2 commits into from

Conversation

tonyhignett
Copy link

@tonyhignett tonyhignett commented May 25, 2021 •
edited
Loading

  • Add graphql to the dependencies, to help interacting with the schema.
  • Get the schema in parallel with the first data query and remember it.
  • Use it to find the numeric fields under the data paths, instead of inspecting the first data point.
  • Fixes Nested value does not work properly #45

Fix plotting series when the first data point is empty.
481bbd7 
- Add `graphql` to the dependencies, to help interacting with the schema.
- Get the schema in parallel with the first data query and remember it.
- Use it to find the numeric fields under the data paths, instead of inspecting the first data point.
@tonyhignett tonyhignett force-pushed the get_types_from_schema branch from d3b2a3c to 481bbd7 Compare May 25, 2021 10:06
@tonyhignett tonyhignett changed the title Fix plotting series when the first data point is empty (fixes #45). Fix plotting series when the first data point is empty Jun 1, 2021
@retzkek
Copy link
Contributor

retzkek commented Jun 4, 2021

Awesome, thank you! Sorry I haven't had a chance to review this yet.

Going to be a bit tricky integrating this and #60...

@SydoxX
Copy link

SydoxX commented Jun 5, 2021

In #60 I tried to keep most of the non-requesting code the same so most of this stuff can be layered on. But RequestFactory will need some rewriting. I'd say we merge #60 first and then cherry-pick the conflicting lines, there shouldn't be too many of them. I'm happy to help with merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested value does not work properly
4 participants
@tonyhignett @retzkek @SydoxX @JonathanWylie