Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make isRFC3339_ISO6801() require string argument #33

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

retzkek
Copy link
Contributor

@retzkek retzkek commented Nov 3, 2020

It doesn't make sense to accept any, and can cause issues like #32. I just coerce the field to a String() in the caller, which I believe should degrade gracefully (and the tests agree).

@retzkek
Copy link
Contributor Author

retzkek commented Nov 3, 2020

@ricochet1k or @carvid could you test this and verify it fixes your issue, before I merge and cut a release?
You can install it directly from github:

cd $GF_PATHS_PLUGINS # or maybe $GF_PLUGIN_DIR. Default is /var/lib/grafana/plugins
git clone https://github.com/retzkek/graphql-datasource.git -b iso-require-string

then restart grafana.

@carvid
Copy link
Contributor

carvid commented Nov 4, 2020

@ricochet1k or @carvid could you test this and verify it fixes your issue, before I merge and cut a release?
You can install it directly from github:

cd $GF_PATHS_PLUGINS # or maybe $GF_PLUGIN_DIR. Default is /var/lib/grafana/plugins
git clone https://github.com/retzkek/graphql-datasource.git -b iso-require-string

then restart grafana.

@retzkek It worked for me.

@carvid
Copy link
Contributor

carvid commented Nov 4, 2020

Hi @retzkek. Any chance to get this fix released soon?. We started to hit the error in several new queries 😬 .

@retzkek
Copy link
Contributor Author

retzkek commented Nov 4, 2020

@carvid thanks for testing. Sure I'll cut a release right now. Note that it will take several days to get the update into the Grafana repo.

@retzkek retzkek merged commit 0460829 into fifemon:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants