Jb/638 cache descendants #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def cached_descendants | ||
| Rails.cache.fetch([self, 'descendants'], expires_in: 1.week) do | ||
| descendant_pages(true) if self.respond_to?(:descendant_pages) | ||
| descendant_groups(true) if self.respond_to?(:descendant_groups) |
There was a problem hiding this comment.
Hier wäre es vermutlich schöner, wenn Du Structureable#descendants überschreibst, sodass Du dann in dieser Methode nur noch descendants(true) aufrufen musst.
def descendants(force_reload = false)
descendant_pages(true) if force_reload && self.respond_to?(:descendant_pages)
# ...
endThere was a problem hiding this comment.
Ja, gute Idee. Leider wurde genau diese Methode in has_dag_links vergessen. Die Methode #descendants ist übrigens tatsächlich lediglich ein Join auf die Methode #descendant_tablenames von jeder Tabelle. Die einzelnen Methoden #descendant_tablenames sind übrigens mit Parameter force_reload versehen.
fiedl
force-pushed
the
master
branch
2 times, most recently
from
b4150a4 to
1be2070
Compare
fiedl
force-pushed
the
master
branch
2 times, most recently
from
3e70e6d to
af086ae
Compare
fiedl
force-pushed
the
master
branch
5 times, most recently
from
4478ccc to
39728aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Das hier muss ich nochmal komplett neu angehen, sobald
acts_as_dagundcached(:method)fertig sind.Beim Löschen eines
DagLinksollte auch der Cache vonancestorunddescendantgelöscht werden.Die Methode
#descendantsliefert erst nach einem#reloaddas korrekte Ergebnis.Alle Verwendungsstellen von
#descendantswurden durch#cached_descendantsersetzt.Die Methode
#cached_descendantsist besser, weil sie intern eindescendant_pages(true)unddescendant_groups(true)aufruft. Jede Klasse, dieis_structureableist, hat mindestensGroupoderPagealsancestor_class_name.