Fixes #4. Create skycoin.net library using swig #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 4, 2018 19:15
…g. Update submodule
5 tasks
olemis
requested changes
Nov 29, 2018
| @@ -0,0 +1,1623 @@ | |||
| /* Created by "go tool cgo" - DO NOT EDIT. */ | |||
There was a problem hiding this comment.
Should use the copy in the skycoin/skycoin submodule .
olemis
requested changes
Nov 29, 2018
| - nuget restore LibskycoinNet.sln | ||
| - nuget install NUnit.Runners -Version 2.6.4 -OutputDirectory testrunner | ||
|
|
||
| script: | ||
| - make build-libc | ||
| - make build-swig |
There was a problem hiding this comment.
Both make targets should be declared as dependencies for make build (see below)
| - msbuild /p:Configuration=Release LibskycoinNet.sln | ||
| - make build-libskycoin-net |
There was a problem hiding this comment.
just make build ... indeed , much better would be ...
| - msbuild /p:Configuration=Release LibskycoinNet.sln | ||
| - make build-libskycoin-net | ||
| - mono ./testrunner/NUnit.Runners.2.6.4/tools/nunit-console.exe ./LibskycoinNetTest/bin/Release/LibskycoinNetTest.dll |
There was a problem hiding this comment.
... to summarize it as a singlemake test target dependent of make build (et al.) and doing exactly this .
m4yk3ldev
referenced
this pull request
Nov 29, 2018
|
superseded by #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Changes: