Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #12 - Generate angular typescript API client for Skycoin hardware wallet daemon #18

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

fixes #12 - Generate angular typescript API client for Skycoin hardware wallet daemon #18

wants to merge 10 commits into from

Conversation

stdevMac
Copy link
Member

@stdevMac stdevMac commented Apr 5, 2019

Fixes #12

Changes:

  • Added typescript-Angular wrapper for Hardware Wallet Deamon

Does this change need to mentioned in CHANGELOG.md?

Yes

Requiere Test

cbermudez97 and others added 9 commits March 29, 2019 12:42
[skyapi] refs fibercrypto#8 - Create .gitignore file
8c04744
[skyapi] refs fibercrypto#8 - Add skycoin.v0.25.1.openapi.v2.yml file
34cd6f3 
This is the openapi specification used to generate the clients.
[skyapi] refs fibercrypto#8 - Create the Makefile file
179c241 
Also a rule to generate the typescript client using axios was created in
the Makefile.
[skyapi] refs fibercrypto#8 - Generate skyapi axios client
68c878a
[skyapi] refs fibercrypto#8 - Create base of the skyapi axios client …
e01481c 
…tester
[skyapi] refs fibercrypto#8 - Create rules to build the skyapi axios …
a202a22 
…client
[skyapi] refs fibercrypto#8 - Create travis configuration file
a9e7020
[skyapi] refs fibercrypto#8 - Use strict mode in the tester index.js
3c70e6d
@stdevIvr
[skyapi] refs fibercrypto#12 - Generate API client for typescript-ang…
b995976 
…ular
@olemis olemis changed the title stdevivr t12 generate api client typescript angular fixes #12 - Generate angular typescript API client for Skycoin hardware wallet daemon Apr 6, 2019
@olemis olemis added stdev wip openapi Related to REST and OpenAPI specs labels Apr 6, 2019
olemis
olemis requested changes Apr 8, 2019
View reviewed changes
Copy link
Collaborator

@olemis olemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should not contain anything related to lib/skyapi , lib/skyhwd only.

olemis
olemis requested changes Apr 8, 2019
View reviewed changes
Copy link
Collaborator

@olemis olemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a simple test for querying /v1/version from a localhost Skycoin node. @stdevIvr did you do so? Please include in Travis , Makefile et al.

@isaacvr isaacvr mentioned this pull request Oct 31, 2019
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemis olemis olemis requested changes

Assignees

@stdevMac stdevMac

Labels
openapi Related to REST and OpenAPI specs stdev wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript Node API wrapper for Skycoin node API
3 participants
@stdevMac @olemis @stdevIvr