Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #12 - Generate nodejs api client #15

Merged
merged 33 commits into from
Jul 24, 2019
Merged

fixes #12 - Generate nodejs api client #15

merged 33 commits into from
Jul 24, 2019

Conversation

cbermudez97
Copy link

Fixes #12

Changes:

  • Created Typescript Skycoin API using node.
  • Added test for the created API to the Tester.
  • Added new test to Travis configuration file.

Does this change need to mentioned in CHANGELOG.md?

No

cbermudez97 added 12 commits March 29, 2019 12:42
[skyapi] refs fibercrypto#8 - Create .gitignore file
8c04744
[skyapi] refs fibercrypto#8 - Add skycoin.v0.25.1.openapi.v2.yml file
34cd6f3 
This is the openapi specification used to generate the clients.
[skyapi] refs fibercrypto#8 - Create the Makefile file
179c241 
Also a rule to generate the typescript client using axios was created in
the Makefile.
[skyapi] refs fibercrypto#8 - Generate skyapi axios client
68c878a
[skyapi] refs fibercrypto#8 - Create base of the skyapi axios client …
e01481c 
…tester
[skyapi] refs fibercrypto#8 - Create rules to build the skyapi axios …
a202a22 
…client
[skyapi] refs fibercrypto#8 - Create travis configuration file
a9e7020
[skyapi] refs fibercrypto#8 - Use strict mode in the tester index.js
3c70e6d
[skyapi] refs fibercrypto#12 - Generate skyapi node client
04764c4
[skyapi] refs fibercrypto#12 - Add test for the node skycoin api
11ed2d1
[skyapi] refs fibercrypto#12 - Add rules to Makefile to build the nod…
d7b8cd7 
…e skycoin api
[skyapi] refs fibercrypto#12 - Add configuration to the .travis.yml f…
812665a 
…ile to build

and test the node skycoin api
@cbermudez97 cbermudez97 requested a review from stdevMac April 3, 2019 23:58
stdevCbermudez added 15 commits April 8, 2019 12:58
[skyapi] refs fibercrypto#8 - Relocate axios generated client and tester
dd5f004
[skyapi] refs fibercrypto#8 - Fix errors in Makefile and Travis confi…
340946c 
…guration file
[skyapi] refs fibercrypto#8 - Fix broken dependencies
b2682d8
[skyapi] refs fibercrypto#8 - Remove innecesary openapi specification
a0eff02
[skyapi] refs fibercrypto#8 - Add test to axios API client using test…
80d74dd 
… frameworks

mocha and chai
[skyapi] refs fibercrypto#8 - Fix dependencies in axios API tester
63bbf22
[skyapi] refs fibercrypto#8 - Fix errors in axios API client tests
c2b40bd
[skyapi] refs fibercrypto#8 - Add nodejs version to Travis configurat…
79a1026 
…ion file
Merge branch 'cbermudez97_t8_generate_api_client_axios' into cbermude…
79f451a 
…z_t12_generate_api_client_node
[skyapi] refs fibercrypto#12 - Relocate node generated client
55e7c99
[skyapi] refs fibercrypto#12 - Add test to node API client using test…
128b864 
… frameworks

mocha and chai
[skyapi] refs fibercrypto#12 - Modify Makefile to add rules to build …
5b59f4f 
…and test node

client
[skyapi] refs fibercrypto#8 - Update the axios client test timeout
dbe61fc
Merge branch 'cbermudez97_t8_generate_api_client_axios' into cbermude…
516f0e2 
…z_t12_generate_api_client_node
[skyapi] refs fibercrypto#12 - Update the node client test timeout
b7bbfae
@cbermudez97 cbermudez97 requested a review from olemis April 12, 2019 20:32
@olemis olemis changed the title Cbermudez t12 generate api client node fixes #12 - Generate api client node Apr 13, 2019
@olemis olemis changed the title fixes #12 - Generate api client node fixes #12 - Generate nodejs api client Apr 13, 2019
olemis
olemis requested changes Apr 13, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
olemis
olemis requested changes Apr 13, 2019
View reviewed changes
Copy link
Collaborator

@olemis olemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove lib/skyapi/axios . This is meant to be merged in #13 .

@olemis olemis added stdev wip openapi Related to REST and OpenAPI specs labels Apr 13, 2019
@olemis olemis added this to the v0.24 milestone Apr 13, 2019
@cbermudez97 cbermudez97 requested a review from olemis April 17, 2019 21:32
@stdevMac stdevMac merged commit b85c77b into fibercrypto:develop Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdevMac stdevMac Awaiting requested review from stdevMac

@olemis olemis Awaiting requested review from olemis

Assignees

@cbermudez97 cbermudez97

Labels
openapi Related to REST and OpenAPI specs stdev wip
Projects
None yet
Milestone
v0.25.1
Development

Successfully merging this pull request may close these issues.

Typescript Node API wrapper for Skycoin node API
3 participants
@cbermudez97 @olemis @stdevMac