Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format with black -l 120 . #199

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Format with black -l 120 . #199

merged 1 commit into from
Jan 12, 2023

Conversation

henrik242
Copy link
Contributor

black provides pretty sane formatting for python, I think.

@henrik242 henrik242 requested a review from a team as a code owner January 5, 2023 10:10
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 5, 2023
View reviewed changes
fiaas_deploy_daemon/deployer/kubernetes/deployment/secrets.py
config.strongbox_init_container_image,
self._available_secrets_containers["strongbox"])
config.strongbox_init_container_image,
self._available_secrets_containers["strongbox"],

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (secret)](1) as clear text. This expression logs [sensitive data (secret)](2) as clear text.
fiaas_deploy_daemon/deployer/kubernetes/deployment/secrets.py
secret-init-container default=%s will be used instead",
config.secrets_init_container_image,
self._available_secrets_containers["default"])
config.secrets_init_container_image,

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (secret)](1) as clear text. This expression logs [sensitive data (secret)](2) as clear text.
fiaas_deploy_daemon/deployer/kubernetes/deployment/secrets.py
config.secrets_init_container_image,
self._available_secrets_containers["default"])
config.secrets_init_container_image,
self._available_secrets_containers["default"],

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (secret)](1) as clear text. This expression logs [sensitive data (secret)](2) as clear text.
mortenlj
mortenlj approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@mortenlj mortenlj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is so many good changes in this PR that I can't be bothered to point out the handful of places where I would have preferred slight changes in the formatting.

👍

@henrik242 henrik242 merged commit ee0629a into master Jan 12, 2023
@henrik242 henrik242 deleted the henrik/formatting branch January 12, 2023 11:46
@oyvindio oyvindio mentioned this pull request Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenlj mortenlj mortenlj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrik242 @mortenlj