Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing configuration to VLS. #86

Merged
merged 3 commits into from
Jan 17, 2022

Conversation

ascott18
Copy link
Contributor

@ascott18 ascott18 commented Nov 15, 2021

Adds support for configuring VLS. All VLS configuration (that which is defined in getDefaultVLSConfig) is candidates for customization. Configuration is passed via CLI arguments in build mode, and by workerData in serve mode.

Tested on Windows 10 and Ubuntu 18.04 (via WSL).

Fixes #85.

@ascott18 ascott18 changed the title Fix #85 - add support for passing configuration to VLS. Add support for passing configuration to VLS. Nov 15, 2021
# Conflicts:
#	packages/vite-plugin-checker/src/checkers/vls/main.ts
#	packages/vite-plugin-checker/src/types.ts
@fi3ework fi3ework changed the base branch from main to v0.4.x January 16, 2022 15:31
@codecov-commenter
Copy link

Codecov Report

Merging #86 (1c375c6) into v0.4.x (2f7a4b4) will decrease coverage by 1.29%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.4.x      #86      +/-   ##
==========================================
- Coverage   38.13%   36.84%   -1.30%     
==========================================
  Files          14       14              
  Lines         645      665      +20     
  Branches      127      140      +13     
==========================================
- Hits          246      245       -1     
- Misses        397      418      +21     
  Partials        2        2              
Impacted Files Coverage Δ
...ckages/vite-plugin-checker/src/checkers/vls/cli.ts 0.00% <0.00%> (ø)
...vite-plugin-checker/src/checkers/vls/initParams.ts 25.00% <ø> (ø)
packages/vite-plugin-checker/src/main.ts 78.66% <ø> (-0.29%) ⬇️
packages/vite-plugin-checker/src/types.ts 100.00% <ø> (ø)
...ite-plugin-checker/src/checkers/vls/diagnostics.ts 12.58% <7.14%> (-1.16%) ⬇️
...kages/vite-plugin-checker/src/checkers/vls/main.ts 42.85% <12.50%> (-8.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7a4b4...1c375c6. Read the comment docs.

@fi3ework
Copy link
Owner

Thanks @ascott18! This will be released in 0.4.0. Great PR!

@fi3ework fi3ework closed this Jan 17, 2022
@fi3ework fi3ework reopened this Jan 17, 2022
@fi3ework fi3ework merged commit 4658492 into fi3ework:v0.4.x Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to customize VLS settings
3 participants