Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix early exit when enableBuild is true #61

Merged
merged 5 commits into from
Jul 31, 2021
Merged

Fix early exit when enableBuild is true #61

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b3fbb9
Fix early exit
fgblomqvist Jul 28, 2021
23b9b3c
Throw error instead of process.exit
fgblomqvist Jul 28, 2021
56b98d2
Run async on build
fgblomqvist Jul 30, 2021
9231af4
Go back to process.exit
fgblomqvist Jul 30, 2021
323076f
Add semi-colons
fgblomqvist Jul 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/vite-plugin-checker/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,23 +62,23 @@ export default function Plugin(userConfig: UserPluginConfig): Plugin {
buildStart: () => {
// for build mode
// run a bin command in a separated process
if (viteMode !== 'build') return
if (viteMode !== 'build') return;

// do not do anything when disable build mode
if (!enableBuild) return
if (!enableBuild) return;

const localEnv = npmRunPath.env({
env: process.env,
cwd: process.cwd(),
execPath: process.execPath,
})

Promise.all(checkers.map((checker) => spawnChecker(checker, userConfig, localEnv))).then(
(exitCodes) => {
const exitCode = exitCodes.find((code) => code !== 0) || 0
process.exit(exitCode)
}
)
});

// spawn an async runner that we don't wait for in order to avoid blocking the build from continuing in parallel
(async () => {
const exitCodes = await Promise.all(checkers.map((checker) => spawnChecker(checker, userConfig, localEnv)));
const exitCode = exitCodes.find((code) => code !== 0) ?? 0;
if (exitCode !== 0) process.exit(exitCode);
})();
},
configureServer(server) {
// for dev mode (2/2)
Expand Down