Intercept function declarations

fhinkel · Jul 27, 2016 · aef3aed · aef3aed
1 parent f3373a7
commit aef3aed
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/deps/v8/src/runtime/runtime-scopes.cc b/deps/v8/src/runtime/runtime-scopes.cc
@@ -44,8 +44,14 @@ static Object* DeclareGlobals(Isolate* isolate, Handle<JSGlobalObject> global,
   }
 
   // Do the lookup own properties only, see ES5 erratum.
-  LookupIterator it(global, name, global,
-                    LookupIterator::HIDDEN_SKIP_INTERCEPTOR);
+  LookupIterator::Configuration configuration =
+      LookupIterator::Configuration::HIDDEN_SKIP_INTERCEPTOR;
+  if (is_function) {
+    // for function declarations, use the interceptor on the declaration,
+    // otherwise use it only on initialization
+    configuration = LookupIterator::Configuration::DEFAULT;
+  }
+  LookupIterator it(global, name, global, configuration);
   Maybe<PropertyAttributes> maybe = JSReceiver::GetPropertyAttributes(&it);
   if (!maybe.IsJust()) return isolate->heap()->exception();
 

diff --git a/...wn_issues/test-vm-function-declaration.js → .../parallel/test-vm-function-declaration.js b/...wn_issues/test-vm-function-declaration.js → .../parallel/test-vm-function-declaration.js