Collision area flips horizontally when user changes direction #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charasyn
reviewed
Mar 30, 2021
godotproject/Player.gd
Outdated
Comment on lines
411
to
414
| if velocity.x > 0: | ||
| scale.x = initial_scale.x * sign(scale.y) | ||
| elif velocity.x < 0: | ||
| scale.x = -initial_scale.x * sign(scale.y) |
There was a problem hiding this comment.
Quick q, why is scale.y involved here? I can't tell why it would be...
Also I think we can use the facing variable, so maybe the code could look something like:
Suggested change
| if velocity.x > 0: | |
| scale.x = initial_scale.x * sign(scale.y) | |
| elif velocity.x < 0: | |
| scale.x = -initial_scale.x * sign(scale.y) | |
| scale.x = sign(facing.x) * initial_scale.x |
There was a problem hiding this comment.
TBH I'm not 100% sure why scale.y needs to be involved here - could be because the initial scale isn't (1,1)? So far it's the only way I've found that keeps the sprite from flickering between left and right. I tried it out and your suggested change results in this flickering too unless I multiply scale.y. I'm going off of the comments in this issue: godotengine/godot#12335
charasyn
requested changes
Mar 30, 2021
charasyn
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inverting based on the scale of the root node so that collision area flips with the sprite (sprite not symmetrical)