Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writeProperty increase counter twice - causing callback to fail #2

Closed
narbuzov opened this issue Apr 13, 2017 · 1 comment
Closed

writeProperty increase counter twice - causing callback to fail #2

narbuzov opened this issue Apr 13, 2017 · 1 comment
Assignees
@fh1ch
Labels
bug
Milestone
0.0.1-beta.3

Comments

@narbuzov
Copy link

narbuzov commented Apr 13, 2017 •
edited
Loading

in bacnet-client.js - writePropery function:
invokeCounter - being increased twice:

Once in line:
baAdpu.encodeConfirmedServiceRequest(buffer, baEnum.BacnetPduTypes.PDU_TYPE_CONFIRMED_SERVICE_REQUEST, baEnum.BacnetConfirmedServices.SERV
ICE_CONFIRMED_WRITE_PROPERTY, maxSegments, baEnum.BacnetMaxAdpu.MAX_APDU1476, invokeCounter++, 0, 0);

Then:
addCallback(invokeCounter++, function(err, data) {

This causes callback to always timeout.
@fh1ch fh1ch self-assigned this Apr 13, 2017
@fh1ch fh1ch added this to the 0.0.1-beta.3 milestone Apr 13, 2017
@fh1ch fh1ch added the bug label Apr 13, 2017
fh1ch added a commit that referenced this issue Apr 14, 2017
@fh1ch
fix(bacnet-client): prevent redundant increment of invoke counter
a59b023 
Closes issue #2
@fh1ch
Copy link
Owner

fh1ch commented Apr 14, 2017

Hi @narbuzov

Thank you very much for your bug report, I really appreciate this 👍

The problem is now solved in the latest release "0.0.1-beta.3".

Cheers

@fh1ch fh1ch closed this as completed Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fh1ch fh1ch

Labels
bug
Projects
None yet
Milestone
0.0.1-beta.3
Development

No branches or pull requests
2 participants
@fh1ch @narbuzov