Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Container to interface #8

Closed
fgm opened this issue Apr 26, 2023 · 0 comments · Fixed by #9
Closed

Convert Container to interface #8

fgm opened this issue Apr 26, 2023 · 0 comments · Fixed by #9
Assignees
@fgm
Labels
enhancement New feature or request

Comments

@fgm
Copy link
Owner

fgm commented Apr 26, 2023

Currently Container is a concrete type, a struct. This makes it inconvenient to use in tests, so it should be converted to an interface.

This will be an incompatible change, which is acceptable for a minor release in 0.x versions.
@fgm fgm self-assigned this Apr 26, 2023
@fgm fgm added the enhancement New feature or request label Apr 26, 2023
fgm added a commit that referenced this issue Apr 26, 2023
@fgm
Issue #8: convert Container to an interface.
7ecd578
@fgm fgm linked a pull request Apr 26, 2023 that will close this issue
Issue #8: convert Container to an interface. #9
Merged
fgm added a commit that referenced this issue Apr 26, 2023
@fgm
Issue #8: convert Container to an interface.
13da027
fgm added a commit that referenced this issue Apr 26, 2023
@fgm
Issue #8: convert Container to an interface.
8a75c1a
fgm added a commit that referenced this issue Apr 26, 2023
@fgm
Issue #8: convert Container to an interface.
4cce990
fgm added a commit that referenced this issue Apr 27, 2023
@fgm
Issue #8: convert Container to an interface.
7753d74
fgm added a commit that referenced this issue Apr 27, 2023
@fgm
Issue #8: convert Container to an interface.
0e14611
fgm added a commit that referenced this issue Apr 27, 2023
@fgm
Issue #8: convert Container to an interface.
355cd30
fgm added a commit that referenced this issue Apr 27, 2023
@fgm
Issue #8: convert Container to an interface.
f50bf7a
fgm added a commit that referenced this issue Apr 28, 2023
@fgm
Issue #8: convert Container to an interface.
296598b
@fgm fgm closed this as completed in #9 Apr 28, 2023
fgm added a commit that referenced this issue Apr 28, 2023
@fgm
Merge pull request #9 from fgm/8-convert-container-to-interface
04c73db 
Issue #8: convert Container to an interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgm fgm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #8: convert Container to an interface. fgm/izidic
1 participant
@fgm