Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New layer architecture #159

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# will have compiled files and executables
target

Cargo.lock

# These are backup files generated by rustfmt
**/*.rs.bk
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
members = [
"greenglas", "coaster", "coaster-nn", "coaster-blas", "juice", "rust-blas",
"rcudnn/cudnn", "rcudnn/cudnn-sys", "rcublas/cublas", "rcublas/cublas-sys",
"juice-examples/juice-utils", "juice-examples/mackey-glass-rnn-regression",
# "juice-examples/juice-utils", "juice-examples/mackey-glass-rnn-regression",
"juice-examples/mnist-image-multiclass-classification"]

exclude = [ "./rcudnn", "./rcublas", "./juice-examples"]
Expand Down
60 changes: 28 additions & 32 deletions juice-examples/mnist-image-multiclass-classification/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ use co::frameworks::cuda::get_cuda_backend;
#[cfg(not(feature = "cuda"))]
use co::frameworks::native::get_native_backend;
use co::prelude::*;
use juice::layer::*;
use juice::layers::*;
use juice::net::*;
use juice::solver::*;
use juice::util::*;
use juice_utils::{download_datasets, unzip_datasets};
Expand Down Expand Up @@ -131,7 +130,7 @@ fn main() {
);
}
}

/*
#[cfg(all(feature = "cuda"))]
fn add_conv_net(
mut net_cfg: SequentialConfig,
Expand Down Expand Up @@ -164,7 +163,7 @@ fn add_conv_net(
"linear1",
LinearConfig { output_size: 500 },
));
net_cfg.add_layer(LayerConfig::new("sigmoid", LayerType::Sigmoid));
net_cfg.add_layer(LayerConfig::new("sigmoid", LayerConfig::Sigmoid));
net_cfg.add_layer(LayerConfig::new(
"linear2",
LinearConfig { output_size: 10 },
Expand Down Expand Up @@ -192,26 +191,25 @@ fn add_mlp(
) -> SequentialConfig {
net_cfg.add_layer(LayerConfig::new(
"reshape",
LayerType::Reshape(ReshapeConfig::of_shape(&[batch_size, pixel_count])),
LayerConfig::Reshape(ReshapeConfig::of_shape(&[batch_size, pixel_count])),
));
net_cfg.add_layer(LayerConfig::new(
"linear1",
LayerType::Linear(LinearConfig { output_size: 1568 }),
LayerConfig::Linear(LinearConfig { output_size: 1568 }),
));
net_cfg.add_layer(LayerConfig::new("sigmoid", LayerType::Sigmoid));
net_cfg.add_layer(LayerConfig::new("sigmoid", LayerConfig::Sigmoid));
net_cfg.add_layer(LayerConfig::new(
"linear2",
LayerType::Linear(LinearConfig { output_size: 10 }),
LayerConfig::Linear(LinearConfig { output_size: 10 }),
));
net_cfg
}

fn add_linear_net(mut net_cfg: SequentialConfig) -> SequentialConfig {
net_cfg.add_layer(LayerConfig::new(
*/
fn add_linear_net(net_cfg: SequentialConfig) -> SequentialConfig{
net_cfg.with_layer(
"linear",
LayerType::Linear(LinearConfig { output_size: 10 }),
));
net_cfg
LayerConfig::Linear(LinearConfig { output_size: 10 }),
)
}

fn run_mnist(
Expand Down Expand Up @@ -250,25 +248,19 @@ fn run_mnist(
let momentum = momentum.unwrap_or(0f32);

let mut net_cfg = SequentialConfig::default();
net_cfg.add_input("data", &[batch_size, pixel_dim, pixel_dim]);
net_cfg.force_backward = true;

net_cfg = match &*model_name.unwrap_or("none".to_owned()) {
"conv" => add_conv_net(net_cfg, batch_size, pixel_dim),
"mlp" => add_mlp(net_cfg, batch_size, pixel_count),
"linear" => add_linear_net(net_cfg),
match &*model_name.unwrap_or("none".to_owned()) {
// "conv" => add_conv_net(net_cfg, batch_size, pixel_dim),
// "mlp" => add_mlp(net_cfg, batch_size, pixel_count),
"linear" => net_cfg = add_linear_net(net_cfg),
_ => panic!("Unknown model. Try one of [linear, mlp, conv]"),
};

net_cfg.add_layer(LayerConfig::new("log_softmax", LayerType::LogSoftmax));
net_cfg = net_cfg.with_layer("log_softmax", LayerConfig::LogSoftmax);

let mut classifier_cfg = SequentialConfig::default();
classifier_cfg.add_input("network_out", &[batch_size, 10]);
classifier_cfg.add_input("label", &[batch_size, 1]);
// set up nll loss
let nll_layer_cfg = NegativeLogLikelihoodConfig { num_classes: 10 };
let nll_cfg = LayerConfig::new("nll", LayerType::NegativeLogLikelihood(nll_layer_cfg));
classifier_cfg.add_layer(nll_cfg);
let classifier_cfg =
LayerConfig::NegativeLogLikelihood(NegativeLogLikelihoodConfig { num_classes: 10 });

// set up backends
#[cfg(all(feature = "cuda"))]
Expand All @@ -283,9 +275,14 @@ fn run_mnist(
momentum,
..SolverConfig::default()
};
solver_cfg.network = LayerConfig::new("network", net_cfg);
solver_cfg.objective = LayerConfig::new("classifier", classifier_cfg);
let mut solver = Solver::from_config(backend.clone(), backend.clone(), &solver_cfg);
solver_cfg.network = LayerConfig::Sequential(net_cfg);
solver_cfg.objective = classifier_cfg;
let mut solver = Solver::from_config(
backend.clone(),
&solver_cfg,
&[vec![pixel_dim, pixel_dim]],
&vec![1],
);

// set up confusion matrix
let mut classification_evaluator = ::juice::solver::ConfusionMatrix::new(10);
Expand All @@ -311,9 +308,8 @@ fn run_mnist(
targets.push(label_val as usize);
}
// train the network!
let infered_out = solver.train_minibatch(inp_lock.clone(), label_lock.clone());
let mut infered = solver.train_minibatch(inp_lock.clone(), label_lock.clone());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


let mut infered = infered_out.write().unwrap();
let predictions = classification_evaluator.get_predictions(&mut infered);

classification_evaluator.add_samples(&predictions, &targets);
Expand Down
6 changes: 6 additions & 0 deletions juice/examples/benchmarks.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/*

#[macro_use]
extern crate timeit;

Expand Down Expand Up @@ -582,3 +584,7 @@ fn bench_vgg_a() {
}
}
}
*/


fn main() {}
6 changes: 4 additions & 2 deletions juice/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,12 @@ extern crate coaster_blas as coblas;
extern crate coaster_nn as conn;
extern crate num;
extern crate rand;
pub mod layer;
pub mod layers;
//pub mod layer;
//pub mod layers;
Comment on lines +120 to +121
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//pub mod layer;
//pub mod layers;

pub mod net;
pub mod solver;
pub mod solvers;
pub mod train;
pub mod weight;

mod capnp_util;
Expand Down
5 changes: 5 additions & 0 deletions juice/src/net/activation/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
mod relu;
mod sigmoid;

pub use relu::*;
pub use sigmoid::*;
53 changes: 53 additions & 0 deletions juice/src/net/activation/relu.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
use crate::co::IBackend;
use crate::conn;
use crate::net::{Context, Descriptor, Layer};

#[derive(Debug, Clone)]
pub struct Relu {
descriptor: Descriptor,
}

impl Relu {
pub fn new(mut descriptor: Descriptor) -> Self {
assert_eq!(descriptor.inputs().len(), 1); // Should only be one input.

descriptor.add_output(descriptor.input(0).unit_shape().clone());

Relu {
descriptor: descriptor,
}
}
}

impl<B: IBackend + conn::Relu<f32>> Layer<B> for Relu {
fn compute_output(&self, backend: &B, context: &mut Context) {
let input = context.get_data(self.descriptor.input(0));
let output = context.acquire_data(self.descriptor.output(0));
backend
.relu(&input.borrow(), &mut output.borrow_mut())
.unwrap();
}

fn compute_gradients(&self, backend: &B, context: &mut Context) {
let input = context.get_data(self.descriptor.input(0));
let output = context.get_data(self.descriptor.output(0));
let output_gradient = context.get_data_gradient(self.descriptor.output(0));
let input_gradient = context.acquire_data_gradient(self.descriptor.input(0));
backend
.relu_grad(
&output.borrow(),
&output_gradient.borrow(),
&input.borrow(),
&mut input_gradient.borrow_mut(),
)
.unwrap();
}

fn descriptor(&self) -> &Descriptor {
&self.descriptor
}

fn descriptor_mut(&mut self) -> &mut Descriptor {
&mut self.descriptor
}
}
53 changes: 53 additions & 0 deletions juice/src/net/activation/sigmoid.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
use crate::co::IBackend;
use crate::conn;
use crate::net::{Context, Descriptor, Layer};

#[derive(Debug, Clone)]
pub struct Sigmoid {
descriptor: Descriptor,
}

impl Sigmoid {
pub fn new(mut descriptor: Descriptor) -> Self {
assert_eq!(descriptor.inputs().len(), 1); // Should only be one input.

descriptor.add_output(descriptor.input(0).unit_shape().clone());

Sigmoid {
descriptor: descriptor,
}
}
}

impl<B: IBackend + conn::Sigmoid<f32>> Layer<B> for Sigmoid {
fn compute_output(&self, backend: &B, context: &mut Context) {
let input = context.get_data(self.descriptor.input(0));
let output = context.acquire_data(self.descriptor.output(0));
backend
.sigmoid(&input.borrow(), &mut output.borrow_mut())
.unwrap();
}

fn compute_gradients(&self, backend: &B, context: &mut Context) {
let input = context.get_data(self.descriptor.input(0));
let output = context.get_data(self.descriptor.output(0));
let output_gradient = context.get_data_gradient(self.descriptor.output(0));
let input_gradient = context.acquire_data_gradient(self.descriptor.input(0));
backend
.sigmoid_grad(
&output.borrow(),
&output_gradient.borrow(),
&input.borrow(),
&mut input_gradient.borrow_mut(),
)
.unwrap();
}

fn descriptor(&self) -> &Descriptor {
&self.descriptor
}

fn descriptor_mut(&mut self) -> &mut Descriptor {
&mut self.descriptor
}
}
Loading