-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New layer architecture #159
Open
hweom
wants to merge
5
commits into
fff-rs:master
Choose a base branch
from
hweom:new_layers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
# will have compiled files and executables | ||
target | ||
|
||
Cargo.lock | ||
|
||
# These are backup files generated by rustfmt | ||
**/*.rs.bk |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
/* | ||
|
||
#[macro_use] | ||
extern crate timeit; | ||
|
||
|
@@ -582,3 +584,7 @@ fn bench_vgg_a() { | |
} | ||
} | ||
} | ||
*/ | ||
|
||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -117,10 +117,12 @@ extern crate coaster_blas as coblas; | |||||
extern crate coaster_nn as conn; | ||||||
extern crate num; | ||||||
extern crate rand; | ||||||
pub mod layer; | ||||||
pub mod layers; | ||||||
//pub mod layer; | ||||||
//pub mod layers; | ||||||
Comment on lines
+120
to
+121
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
pub mod net; | ||||||
pub mod solver; | ||||||
pub mod solvers; | ||||||
pub mod train; | ||||||
pub mod weight; | ||||||
|
||||||
mod capnp_util; | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
mod relu; | ||
mod sigmoid; | ||
|
||
pub use relu::*; | ||
pub use sigmoid::*; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
use crate::co::IBackend; | ||
use crate::conn; | ||
use crate::net::{Context, Descriptor, Layer}; | ||
|
||
#[derive(Debug, Clone)] | ||
pub struct Relu { | ||
descriptor: Descriptor, | ||
} | ||
|
||
impl Relu { | ||
pub fn new(mut descriptor: Descriptor) -> Self { | ||
assert_eq!(descriptor.inputs().len(), 1); // Should only be one input. | ||
|
||
descriptor.add_output(descriptor.input(0).unit_shape().clone()); | ||
|
||
Relu { | ||
descriptor: descriptor, | ||
} | ||
} | ||
} | ||
|
||
impl<B: IBackend + conn::Relu<f32>> Layer<B> for Relu { | ||
fn compute_output(&self, backend: &B, context: &mut Context) { | ||
let input = context.get_data(self.descriptor.input(0)); | ||
let output = context.acquire_data(self.descriptor.output(0)); | ||
backend | ||
.relu(&input.borrow(), &mut output.borrow_mut()) | ||
.unwrap(); | ||
} | ||
|
||
fn compute_gradients(&self, backend: &B, context: &mut Context) { | ||
let input = context.get_data(self.descriptor.input(0)); | ||
let output = context.get_data(self.descriptor.output(0)); | ||
let output_gradient = context.get_data_gradient(self.descriptor.output(0)); | ||
let input_gradient = context.acquire_data_gradient(self.descriptor.input(0)); | ||
backend | ||
.relu_grad( | ||
&output.borrow(), | ||
&output_gradient.borrow(), | ||
&input.borrow(), | ||
&mut input_gradient.borrow_mut(), | ||
) | ||
.unwrap(); | ||
} | ||
|
||
fn descriptor(&self) -> &Descriptor { | ||
&self.descriptor | ||
} | ||
|
||
fn descriptor_mut(&mut self) -> &mut Descriptor { | ||
&mut self.descriptor | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
use crate::co::IBackend; | ||
use crate::conn; | ||
use crate::net::{Context, Descriptor, Layer}; | ||
|
||
#[derive(Debug, Clone)] | ||
pub struct Sigmoid { | ||
descriptor: Descriptor, | ||
} | ||
|
||
impl Sigmoid { | ||
pub fn new(mut descriptor: Descriptor) -> Self { | ||
assert_eq!(descriptor.inputs().len(), 1); // Should only be one input. | ||
|
||
descriptor.add_output(descriptor.input(0).unit_shape().clone()); | ||
|
||
Sigmoid { | ||
descriptor: descriptor, | ||
} | ||
} | ||
} | ||
|
||
impl<B: IBackend + conn::Sigmoid<f32>> Layer<B> for Sigmoid { | ||
fn compute_output(&self, backend: &B, context: &mut Context) { | ||
let input = context.get_data(self.descriptor.input(0)); | ||
let output = context.acquire_data(self.descriptor.output(0)); | ||
backend | ||
.sigmoid(&input.borrow(), &mut output.borrow_mut()) | ||
.unwrap(); | ||
} | ||
|
||
fn compute_gradients(&self, backend: &B, context: &mut Context) { | ||
let input = context.get_data(self.descriptor.input(0)); | ||
let output = context.get_data(self.descriptor.output(0)); | ||
let output_gradient = context.get_data_gradient(self.descriptor.output(0)); | ||
let input_gradient = context.acquire_data_gradient(self.descriptor.input(0)); | ||
backend | ||
.sigmoid_grad( | ||
&output.borrow(), | ||
&output_gradient.borrow(), | ||
&input.borrow(), | ||
&mut input_gradient.borrow_mut(), | ||
) | ||
.unwrap(); | ||
} | ||
|
||
fn descriptor(&self) -> &Descriptor { | ||
&self.descriptor | ||
} | ||
|
||
fn descriptor_mut(&mut self) -> &mut Descriptor { | ||
&mut self.descriptor | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍