Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CLI configuration #31

Merged
merged 5 commits into from
Apr 14, 2022
Merged

Refactor CLI configuration #31

merged 5 commits into from
Apr 14, 2022

Conversation

dmke
Copy link
Contributor

@dmke dmke commented Apr 14, 2022

This moves the CLI configuration into an internal package and adds tests.

@dmke
Copy link
Contributor Author

dmke commented Apr 14, 2022

This now also runs go test and golangci-lint run on the CI.

Example run here: https://github.com/digineo/unms-exporter/actions/runs/2169295254

mraerino
mraerino reviewed Apr 14, 2022
View reviewed changes
Copy link
Member

@mraerino mraerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great refactor. glad we are getting some tests in place.
just one remark

internal/cli/config/config_test.go Outdated Show resolved Hide resolved
mraerino
mraerino approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@mraerino mraerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@mraerino mraerino merged commit df5f73a into ffddorf:main Apr 14, 2022
@dmke dmke deleted the chore/config branch April 15, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraerino mraerino mraerino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmke @mraerino