♻️ Refactor Flux kustomizations for apps #51
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomaster
force-pushed
the
refactor-flux-kustomizations
branch
2 times, most recently
from
9edbdb8 to
0eac3b5
Compare
Move apps from the central Flux kustomization to dedicated resources. Follow the template repo [flux2-kustomize-helm-example](https://github.com/fluxcd/flux2-kustomize-helm-example)
nomaster
force-pushed
the
refactor-flux-kustomizations
branch
from
0eac3b5 to
037004c
Compare
|
I'm not sure if we really should go through with this. And if the cluster explodes as soon as we merge the PR. |
mraerino
reviewed
Feb 25, 2024
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| resources: | ||
| - cert-manager.yaml |
There was a problem hiding this comment.
some resources are in the same directory, but missing here:
external-dns.yamlmetallb.yaml
Comment on lines
+5
to
+10
| - ../base/cert-manager | ||
| - ../base/dendrite | ||
| - ../base/cryptpad | ||
| - ../base/external-dns | ||
| - ../base/grafana | ||
| - ../base/prometheus |
There was a problem hiding this comment.
why are all of these paths prefixed with base? what makes an app belong into base?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move apps from the central Flux kustomization to dedicated resources.
Follow the template repo
flux2-kustomize-helm-example