Wrap errors in SMTPError to comply with Adapter.deliver/2 spec #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #177, this adapter was updated to comply with the new spec in Bamboo v2.
However, as suggested in this comment, it is still necessary to wrap the errors in
SMTPError
. This is because theAdapter.error/0
spec requires that theerror
must be aException.t() | String.t()
.Currently,
bamboo_smtp
is returning the underlying error tuple fromgen_smtp
, which is a violation of the spec and causes Elixir to complain when Bamboo raises the exception. An example I have seen in server logs:This PR wraps the errors in
SMTPError
to comply with the spec, so that it can be successfully raised by Bamboo without causingArgumentError
s fromraise
.