Allow overriding the SMTP envelope from #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SMTP `MAIL FROM` command can specify a different address than the one on the `From:` header. This address is called the 'envelope from' and is used by MTAs for reporting bounced emails, amongst others. This patch allows overriding the envelope from address by putting an email address in the `:envelope_from` key of the `private` data of the Bamboo email struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SMTP
MAIL FROMcommand can specify a different address than theone on the
From:header. This address is called the 'envelope from'and is used by MTAs for reporting bounced emails, amongst others.
This patch allows overriding the envelope from address by putting an
email address in the
:envelope_fromkey of theprivatedata of theBamboo email struct.
reference: https://www.xeams.com/difference-envelope-header.htm