Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when providing a custom config and using response: true #142

Closed
ream88 opened this issue May 26, 2020 · 1 comment
Closed

Issue when providing a custom config and using response: true #142

ream88 opened this issue May 26, 2020 · 1 comment

Comments

@ream88
Copy link

ream88 commented May 26, 2020

Thanks to #122 we can now provide a response: true flag when sending an email, however when using this flag in combination with a config: map, the whole thing errors:

config = %{server: "..."}
BambooTrial.Mailer.deliver_now(BambooTrial.Email.test_email(), config: config, response: true)

errors with:

** (ArgumentError) The following settings have not been found in your settings:

* Key port is required for SMTP Adapter
* Key server is required for SMTP Adapter

They are required to make the SMTP adapter work. Here you configuration:

%{adapter: Bamboo.SMTPAdapter}

    (bamboo_smtp 2.1.0) lib/bamboo/adapters/smtp_adapter.ex:342: Bamboo.SMTPAdapter.raise_on_missing_configuration/2
    (bamboo_smtp 2.1.0) lib/bamboo/adapters/smtp_adapter.ex:84: Bamboo.SMTPAdapter.handle_config/1
    (bamboo 1.5.0) lib/bamboo/mailer.ex:292: Bamboo.Mailer.handle_adapter_config/1
@ream88
Copy link
Author

ream88 commented May 26, 2020

Ok, this is an issue in bamboo itself, I will close this issue once the bamboo issue is closed! 😊

@ream88 ream88 closed this as completed Jun 1, 2020
MatheusBueno782 added a commit that referenced this issue Nov 2, 2020
Bump bamboo 1.6
This pull request updates bamboo to 1.6 that brings the fix for the issue #142 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant