Maps integration without voice/modal #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests, this addition just brings the possibility to show the Maps integrated without the need for voice or modal module. This adjustments are more a draft than a really good and well coded solution. And well, i tried to solve a feature request from the past. I wanted it too. My Mirror don't have any microphones or speakers connected. So i have not passed any tests with microphone. There could maybe side effects i'm not aware of.
I added also a map marker icon as svg style. But without configurable options.
I changed the max visible map marker output to the 'max' configurable option.
For usage, i added a new variable to config.js MMM-Fuel config part:
showMapIntegrated: true,
So, feel free to take this as a idea for further development.