Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds builder as separate package #213

Merged
merged 9 commits into from
Jul 15, 2019
Merged

Adds builder as separate package #213

merged 9 commits into from
Jul 15, 2019

Conversation

NothingEverHappens
Copy link
Contributor

No description provided.

@kirjs
Copy link
Contributor

kirjs commented Jul 7, 2019

Now builder is treated as a separate package an has it's own binary.

This is how you debug it:
node --inspect-brk ./node_modules/.bin/builder-30-seconds serve

@fetis fetis self-requested a review July 14, 2019 21:38
@fetis
Copy link
Owner

fetis commented Jul 14, 2019

node --inspect-brk ./node_modules/.bin/builder-30-seconds serve

I think we need to add DEVELOPMENT.md and add this line there

Copy link
Owner

@fetis fetis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally, looks good to me.

I think 2 things missed (can be added in next PRs)

  1. styles are still served from builder directory
  2. instead of picking up config from config folder, specify file as parameter with some defaults

@fetis fetis self-assigned this Jul 15, 2019
@fetis fetis changed the title Add typescript Adds builder as separate package Jul 15, 2019
@fetis fetis merged commit 2684810 into master Jul 15, 2019
@fetis fetis deleted the typesrcipt branch July 15, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants