Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make viewer endpoints public when the security is enabled #146

Closed
fescobar opened this issue Jan 10, 2021 · 3 comments
Closed

Make viewer endpoints public when the security is enabled #146

fescobar opened this issue Jan 10, 2021 · 3 comments
Labels
new feature New Feature released Released

Comments

@fescobar
Copy link
Owner

Any user could have access to the viewer endpoints without credentials. If the user wants to request admin endpoints, it will need admin credentials.
@fescobar fescobar added new feature New Feature backlog Backlog labels Jan 10, 2021
@fescobar fescobar mentioned this issue Jan 10, 2021
Closed
@fescobar
Copy link
Owner Author

FYI @nodlesh

fescobar added a commit that referenced this issue Jan 13, 2021
@fescobar
#146-Make viewer endpoints public when the security is enabled
9e4d4bf
@fescobar fescobar added work in progress Work in progress and removed backlog Backlog labels Jan 13, 2021
fescobar added a commit that referenced this issue Jan 14, 2021
@fescobar
#146-Make viewer endpoints public when the security is enabled
c8ee94b
fescobar added a commit that referenced this issue Jan 14, 2021
@fescobar
#146-Make viewer endpoints public when the security is enabled
45cc874
fescobar added a commit that referenced this issue Jan 14, 2021
@fescobar
#146-Make viewer endpoints public when the security is enabled
274f650
@fescobar fescobar mentioned this issue Jan 15, 2021
Closed
@fescobar
Copy link
Owner Author

Related to fescobar/allure-docker-service-ui#16

@fescobar fescobar added testing Testing and removed work in progress Work in progress labels Jan 17, 2021
fescobar added a commit that referenced this issue Jan 17, 2021
@fescobar
#146-Make viewer endpoints public when the security is enabled
04d2a35
@fescobar fescobar added ready to be released Ready to be released and removed testing Testing labels Jan 18, 2021
This was referenced Jan 18, 2021
Merged
Merged
@fescobar
Copy link
Owner Author

@nodlesh this feature was released from version 2.13.8:

Check documentation here:
https://github.com/fescobar/allure-docker-service#make-viewer-endpoints-public
https://github.com/fescobar/allure-docker-service/releases/tag/v2.13.8
https://github.com/fescobar/allure-docker-service-ui/releases/tag/v7.0.3

Thank you for your suggestions. It's a great feature.

@fescobar fescobar added released Released and removed ready to be released Ready to be released labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature New Feature released Released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fescobar