-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move arithmetic to its own crate #17
Comments
The implementation of |
Issue #50 notes that comparison is lexicographic, not arithmetic. This makes for incorrect behavior when performing arithmetic governed by comparison! This problem raises the severity of this issue. As such, I plan to remove the arithmetic implementations from this crate this year, ideally in the next release. |
Nobody has asked about varint support in the crate, so I'm going to close this. |
Signed-off-by: wcampbell <[email protected]>
As mentioned in #16, the default numeric arithmetic implementations may not be suitable for all use cases of bit sequences. Furthermore, the core crate does not include suitability as a numeric type in its design goals – the minimum product is a sequence of raw bits, with no further semantic information held in the sequence itself.
This issue proposes moving all numeric behavior out of the core crate, into a separate sibling crate (
bitvec_arith
?bitvec_num
?) with wrapper types overBitSlice
andBitVec
that perform numeric arithmetic using the underlying sequences as the n-ary number storage.The text was updated successfully, but these errors were encountered: