BREAKING: Use ES class; drop inherits dep
#530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an ES class so we can drop the `inherits` dependency. All the WebRTC environments we support have supported ES classes for a long time. All usages of `Peer()` must be replaced with `new Peer()` now. This was always the way code examples in the readme have been written.
nazar-pc
approved these changes
Aug 17, 2019
It's stage 3. Should be possible relatively soon. https://github.com/tc39/proposal-class-fields |
FredZeng
pushed a commit
to FredZeng/simple-peer
that referenced
this pull request
Oct 14, 2023
BREAKING: Use ES class; drop `inherits` dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an ES class so we can drop the
inheritsdependency. All the WebRTC environments we support have supported ES classes for a long time.All usages of
Peer()must be replaced withnew Peer()now. This was always the way code examples in the readme have been written.I know this is a lot of code to review. The only transformations I made were:
inheritsdep.selftothisvar self = thisFor: brave/brave-browser#5490