Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(php): Redeclare generate methods for library consumers #5936

Merged
merged 1 commit into from
Feb 8, 2025
Merged

fix(php): Redeclare generate methods for library consumers #5936

merged 1 commit into from
Feb 8, 2025

Conversation

amckinney
Copy link
Member

This updates the exported DynamicSnippetGenerator interface so that the generate methods are visible to consumers of the snippet generator packages (i.e. in the snippets library).

@amckinney amckinney requested a review from dsinghvi as a code owner February 8, 2025 16:31
@amckinney amckinney merged commit 46af0fb into main Feb 8, 2025
49 checks passed
@amckinney amckinney deleted the amckinney/public branch February 8, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsinghvi dsinghvi dsinghvi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amckinney @dsinghvi