Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): respect unions v1 config in generators.yml #5565

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix(cli): respect unions v1 config in generators.yml #5565

merged 2 commits into from
Jan 9, 2025

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Jan 9, 2025 •
edited
Loading

Description

Fixes a bug where the OpenAPI parser stopped respecting the =unions: v1 setting in your generators.yml which configures the parser to generate more idiomatic discriminated unions.

Changes Made

  • loadAPIWorkspace.ts respects shouldUseUndiscriminatedUnionsWithLiterals feature flag

Testing

  • Unit tests added/updated
  • Manual testing completed

@dsinghvi dsinghvi marked this pull request as ready for review January 9, 2025 18:11
@dsinghvi dsinghvi requested a review from amckinney January 9, 2025 18:11
@dsinghvi dsinghvi merged commit 0af8954 into main Jan 9, 2025
51 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/respect-unions-v1 branch January 9, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amckinney amckinney amckinney approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsinghvi @amckinney