-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(php): Implement RawClient.php #4625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcb6
reviewed
Sep 12, 2024
dcb6
reviewed
Sep 12, 2024
dcb6
reviewed
Sep 12, 2024
dcb6
reviewed
Sep 12, 2024
dcb6
reviewed
Sep 12, 2024
dcb6
reviewed
Sep 12, 2024
dcb6
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a variety of the
Core
package utilities, all of which are required for theRawClient
type, which is the primary mechanism used to make HTTP requests.Several things to note:
BaseApiRequest
will be used by every flavor of HTTP endpoint call (i.e. JSON, multipart form, streaming, etc).RawClientTest.php
file is a set of simple tests to confirm theRawClient
acts as expected.RawClient
currently uses the synchronous method call.async
.namespace
from the originalPhpProject
PR here.