Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(php): Implement RawClient.php #4625

Merged
merged 8 commits into from
Sep 12, 2024
Merged

feat(php): Implement RawClient.php #4625

merged 8 commits into from
Sep 12, 2024

Conversation

amckinney
Copy link
Member

@amckinney amckinney commented Sep 12, 2024

This adds a variety of the Core package utilities, all of which are required for the RawClient type, which is the primary mechanism used to make HTTP requests.

Several things to note:

  1. The BaseApiRequest will be used by every flavor of HTTP endpoint call (i.e. JSON, multipart form, streaming, etc).
    • For now, we only implement JSON.
  2. The RawClientTest.php file is a set of simple tests to confirm the RawClient acts as expected.
    • We can add more tests over time, but this at least sets the stage.
  3. The RawClient currently uses the synchronous method call.
    • This will either be refactored to be exclusively async, or an additional method will be rolled out to support those use cases.
    • It's unclear if we will need to support both options, or simply just async.
  4. Tidies up a few things w.r.t. namespace from the original PhpProject PR here.

@amckinney amckinney marked this pull request as ready for review September 12, 2024 20:16
@amckinney amckinney requested a review from dsinghvi as a code owner September 12, 2024 20:16
@amckinney amckinney merged commit 39e8f85 into main Sep 12, 2024
44 checks passed
@amckinney amckinney deleted the amckinney/php/raw-client branch September 12, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants