Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Structural Changes (and some content) For Spin 2 Documentation Release - approved and ready #993

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

karthik2804
Copy link
Contributor

@karthik2804 karthik2804 commented Nov 1, 2023

I have created a new commit to your v2 update that adds a canonical URL entry into the [extra] section of every v1 .md file that has a canonical v2 equivalent.
8e3cd25

Signed-off-by: karthik2804 <[email protected]>
@tpmccallum
Copy link
Contributor

Thanks @karthik2804 will test this out now and comment below.

@tpmccallum
Copy link
Contributor

Hi @karthik2804
The canonical HTML elements are not in the files in the /spin/v1/ path.
Do you need more information about how to create these or how they should look/work?
Basically, every page in the v1 path (that has a similar v2 page; which is most of them at this point of divergence) should have the HTML element that points to the equivalent v2 page. This is a really important part of the SEO once we flip the switch to 2.0.
Other than the canonical work this is looking really great. Testing well on localhost.

@tpmccallum
Copy link
Contributor

Hi @karthik2804
I have created a new commit to your v2 update that adds a canonical URL entry into the [extra] section of every v1 .md file that has a canonical v2 equivalent.
8e3cd25

Copy link
Contributor

@tpmccallum tpmccallum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: karthik2804 <[email protected]>
@tpmccallum tpmccallum changed the title prepare for v2 launch All Structural Changes (and some content) For Spin 2 Documentation Release - approved and ready Nov 3, 2023
@tpmccallum tpmccallum merged commit ffb4f2d into fermyon:main Nov 4, 2023
@karthik2804 karthik2804 deleted the prepare_for_spin_v2 branch November 4, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants