Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update spin 3 docs to represent js sdk v3 structure #1472

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

karthik2804
Copy link
Contributor

Updates examples to look like the JS SDK v3

ref: spinframework/spin-js-sdk#319

@karthik2804 karthik2804 requested a review from itowlson January 28, 2025 13:25
Copy link
Contributor

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some small things, nothing major

content/spin/v3/ai-sentiment-analysis-api-tutorial.md Outdated Show resolved Hide resolved
content/spin/v3/ai-sentiment-analysis-api-tutorial.md Outdated Show resolved Hide resolved
content/spin/v3/key-value-store-tutorial.md Outdated Show resolved Hide resolved
content/spin/v3/serverless-ai-hello-world.md Outdated Show resolved Hide resolved
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine to me but I'm ignorant; if Till is happy then I am happy!

Signed-off-by: karthik2804 <[email protected]>
@karthik2804 karthik2804 merged commit f679270 into fermyon:main Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants