Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix if else clause in spin_main.hbs #1395

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix if else clause in spin_main.hbs #1395

merged 1 commit into from
Oct 8, 2024

Conversation

karthik2804
Copy link
Contributor

@itowlson here are the crimes needed to make the spin sidebar work with v3.

@karthik2804 karthik2804 requested a review from itowlson October 8, 2024 09:11
itowlson
itowlson approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRIMETASTIC

Would you be able to do this in templates/page_lang.hbs please, or would you prefer me to apply the same fix there directly? Thanks either way!

@itowlson itowlson merged commit 10eac4f into fermyon:v3-content Oct 8, 2024
1 check passed
@itowlson
Copy link
Contributor

itowlson commented Oct 8, 2024

I've applied the fix to page_lang.hbs on the parent branch. Thanks again for figuring this one out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson itowlson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karthik2804 @itowlson