Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component dependencies docs #1393

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

itowlson
Copy link
Contributor

@itowlson itowlson commented Oct 8, 2024

@fibonacci1729 ignore previous message, this is the good stuff. Well hopefully

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep $'\r' | wc -l and expect 0 as a result)
  • Has passed bart check
  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

@itowlson itowlson requested a review from fibonacci1729 October 8, 2024 01:19
@itowlson itowlson force-pushed the component-dependencies branch from 0c7b300 to 11a96e3 Compare October 8, 2024 01:55
@itowlson itowlson linked an issue Oct 8, 2024 that may be closed by this pull request
@itowlson itowlson marked this pull request as ready for review October 8, 2024 02:24
@itowlson itowlson force-pushed the component-dependencies branch from 11a96e3 to fb42715 Compare October 8, 2024 03:29
@itowlson
Copy link
Contributor Author

@fibonacci1729 do you have bandwidth to look at this please? Appreciate you're busy of course

@fibonacci1729
Copy link
Contributor

Yes! Sorry about that. I will make time for this tomorrow. Thanks for your patience.

Copy link
Contributor

@fibonacci1729 fibonacci1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @itowlson, thank you again!

@itowlson itowlson merged commit 77ccb29 into fermyon:v3-content Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component dependencies feature
2 participants