Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pycurl for Xray #640

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Use Pycurl for Xray #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3f3a41
use pycurl for xray
zerismo Feb 25, 2025
aa1c0ea
Update version for fennel
zerismo Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fennel/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## [1.5.80] - 2025-02-25
- Use pycurl for xray

## [1.5.79] - 2025-02-15
- Bump pyarrow to 16.0.0

Expand Down
6 changes: 3 additions & 3 deletions fennel/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,9 +867,9 @@ def xray(
url = base_url

response = self._get(url)
if response.status_code != requests.codes.OK:
raise Exception(response.json())
return response.json()
if response["status_code"] != 200:
raise Exception(response["body"])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raising an exception with response["body"] might expose internal details; consider wrapping it in a custom error message.

Suggested change
raise Exception(response["body"])
raise Exception("Error occurred: " + response["body"])

return response["body"]

def inspect(
self, dataset: Union[str, Dataset], n: int = 10
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "fennel-ai"
version = "1.5.79"
version = "1.5.80"
description = "The modern realtime feature engineering platform"
authors = ["Fennel AI <[email protected]>"]
packages = [{ include = "fennel" }]
Expand Down
Loading