thunder: Create a new package for glue

[aditya-nambiar]

Important

Add conditional import for pycurl in client.py and modify pyproject.toml for building fennel-glue-ai.

• Imports:
  • Conditional import of pycurl in client.py to handle ImportError.
• Build Configuration:
  • Modify pyproject.toml to include comments for building fennel-glue-ai.
  • Suggest commenting out pycurl dependency when building fennel-glue-ai.

^{This description was created by for 10945df. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to d8185e8 in 16 seconds

More details

• Looked at 52 lines of code in 2 files
• Skipped 1 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. fennel/client/client.py:13

• Draft comment:
  The import of pycurl is wrapped in a try-except block, but the code does not handle the case where pycurl is not available. Ensure that pycurl is checked for None before use to avoid runtime errors.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_7zA05MJMeoCfSbJD

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 10945df in 15 seconds

More details

• Looked at 58 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. fennel/client/client.py:16

• Draft comment:
  Consider adding a check for pycurl before using it in the code to avoid runtime errors if it's not installed.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The import of pycurl is wrapped in a try-except block to handle the ImportError, which is a good practice for optional dependencies. However, the code does not handle the case where pycurl is not installed, which could lead to runtime errors if any functionality relying on pycurl is used without checking its availability.

2. pyproject.toml:27

• Draft comment:
  Consider automating the process of excluding pycurl when building for fennel-glue-ai to avoid manual errors.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The comment in the pyproject.toml file suggests commenting out the pycurl dependency when building for fennel-glue-ai. This is a manual step that could be error-prone. It would be better to automate this process or provide a script to handle it.

Workflow ID: wflow_qaaIiXPmja9X6Txg

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.