Fixes jwt authenticator restore method to schedule access token refresh after page reload #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 11, 2015 15:35
…ke restore after page refresh
…tead of expiresAt
| } | ||
| resolve(data); | ||
| } else if (_this.refreshAccessTokens) { | ||
| resolve(_this.refreshAccessToken(data.token).then(function () { | ||
| resolve(_this.refreshAccessToken(data.token).then(function () { |
There was a problem hiding this comment.
Are we sure this should be data.token? Not immediately sure.
|
@jpadilla updated that to use tokenPropertyName which seems more correct :) |
jpadilla
added a commit
that referenced
this pull request
Apr 18, 2015
Fixes jwt authenticator restore method to schedule access token refresh after page reload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restore method was not functioning after a page reload due to inconsistency with stored token expire name... Updated it to use the tokenExpireName throughout and restored functionality